Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Qt Deprecated Warnings Part 3 #5457

Merged
merged 12 commits into from
Jul 19, 2024

Conversation

amystamile-usgs
Copy link
Contributor

Description

QXmlDefaultHandler -> QXmlStreamReader

Related Issue

How Has This Been Validated?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added myself to the .zenodo.json document.
  • I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@amystamile-usgs amystamile-usgs changed the title Remove Qt Depreciated Warnings Part 3 Remove Qt Deprecated Warnings Part 3 Apr 4, 2024
Copy link
Contributor

@chkim-usgs chkim-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise.

isis/src/control/objs/BundleSettings/unitTest.cpp Outdated Show resolved Hide resolved
chkim-usgs
chkim-usgs previously approved these changes Apr 4, 2024
@chkim-usgs chkim-usgs dismissed their stale review May 17, 2024 14:56

Verify tests pass first.

@amystamile-usgs
Copy link
Contributor Author

The follow test is failing:

1201 - ThreeImageNetwork.BundleSolutionInfoSerialization (SEGFAULT)

@amystamile-usgs
Copy link
Contributor Author

Tests are passing.

Copy link
Contributor

@chkim-usgs chkim-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again on my local Mac machine, looks good.

@amystamile-usgs amystamile-usgs merged commit a4bc28d into DOI-USGS:dev Jul 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants