Hotfix/2025 02 24 4067 point in time scroll #2459
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIT iteration and anon export
Uses search_after (and optionally PIT searching) to improve full index iteration performance, and introduces some performance enhancements to the anon_export process
This PR...
Developer Checklist
Developers should review and confirm each of these items before requesting review
constants
ormessages
filesdates
)url_for
not hard-codeddevelop
Reviewer Checklist
Reviewers should review and confirm each of these items before approval
If there are multiple reviewers, this section should be duplicated for each reviewer
constants
ormessages
filesdates
)url_for
not hard-codeddevelop
Testing
This needs to be deployed to test, and then anon_export run. First from the command line to confirm behaviour, and then also by schedule using the background jobs. If both are successful, then the next step is to ensure that the data can be re-imported from the export. To do that, export to the local machine, and then re-import from the local machine.
To export to the local machine, ensure the following setting:
To import from the local machine run the command with the following arguments
Deployment
Scripts
Once this has been deployed, the
anon_export.py
script should be run immediately to bring the anonymous data on S3 up to latestNew Infrastructure
By default this code DOES NOT require any infrastructure changes. It uses a
search_after
approach which will work on the current infrastructure, but does not absolutely guarantee the coherence of the output (probably good enough for testing).This code change also allows for the possibility of using PIT search, which is only available in the
default
distributin of ES 7.10.x, that WILL NOT WORK on OSS 7.10.It also WILL NOT WORK on OpenSearch of any version, though PIT is supported in OS 2.x, it is not known if the ES client library will work with it, as the codebases have diverged.Therefore, to use the PIT features we will need to upgrade our ES instance.