-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/1797 maned report page #2454
base: develop
Are you sure you want to change the base?
Conversation
…l work over journals and applications
…orts page, plus some prototype range selecting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Works as expected
{# }#} | ||
{# });#} | ||
{# });#} | ||
{# });#} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leftover commented-out code - can this be deleted?
<link rel="stylesheet" href="/static/vendor/edges/css/bs3.DateHistogramSelectorRenderer.css?v={{config.get('DOAJ_VERSION')}}"> | ||
<style> | ||
#reporting_tools_divider hr { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see other facet dividers—could this be generalized? I suggest moving it to a SCSS file (_search.scss
should work), and using a class (eg. facet-divider
) instead of an ID.
} | ||
|
||
.doaj-multidaterange-facet a { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't found this class in the code, can this be removed? If not then I suggest moving it to a scss file as well.
Add reporting features for Managing Editors
Adds new search controls and a generalised csv exporter to produce journal and application reports
This PR...
Developer Checklist
Developers should review and confirm each of these items before requesting review
constants
ormessages
filesdates
)url_for
not hard-codeddevelop
Reviewer Checklist
Reviewers should review and confirm each of these items before approval
If there are multiple reviewers, this section should be duplicated for each reviewer
constants
ormessages
filesdates
)url_for
not hard-codeddevelop
Testing
Functional Test scripts are under "Report Export" in testbook:
https://doaj.github.io/doaj-docs/feature/1797_maned_report_page/testbook/index.html#report_export/report_export_application
https://doaj.github.io/doaj-docs/feature/1797_maned_report_page/testbook/index.html#report_export/report_export_journal
Deployment
No deployment considerations