Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2832 form subject browser #2420

Open
wants to merge 30 commits into
base: develop
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
ca82c4b
introduce stringSearch flag
amdomanska Feb 12, 2024
a309f43
functional tests
amdomanska Feb 12, 2024
867eefb
make sure the last search term stays in the tree subject
amdomanska Mar 14, 2024
1684537
filter tree when term
amdomanska Mar 14, 2024
6a58474
scroll to the last position in filter tree
amdomanska Mar 14, 2024
f5c31e4
fix scrolling in filtered component
amdomanska Mar 18, 2024
d399550
remove comment
amdomanska Mar 19, 2024
eb401b4
update edges to reset subject browser on clear all
amdomanska Mar 25, 2024
9729a76
Merge branch 'develop' into feature/2832_subject_tree_rendering_changes
amdomanska Apr 29, 2024
e593b56
remember last clicked element and scroll when appropriate
amdomanska Apr 30, 2024
f0980f4
fix final scroll positioning issues in search scroll
richard-jones Jul 4, 2024
3bd9fee
use standard doaj renderer
amdomanska Sep 3, 2024
cfacb3f
use edges helper rather than the ternary operator
amdomanska Sep 3, 2024
e01f9df
first pass on refactoring
amdomanska Sep 12, 2024
ab19b25
edges changes
amdomanska Sep 12, 2024
2b6476c
Merge branch 'develop' into feature/2832_form_subject_browser
amdomanska Sep 12, 2024
4ad068d
changes to edges
amdomanska Sep 16, 2024
fc66630
search tree selector works
amdomanska Sep 23, 2024
2c7ae60
form subject selector
amdomanska Sep 23, 2024
bac15b1
Merge branch 'develop' into feature/2832_subject_tree_rendering_changes
amdomanska Sep 23, 2024
e294638
Merge branch 'feature/2832_subject_tree_rendering_changes' into featu…
amdomanska Sep 23, 2024
3cfb6dc
remove comments and console.logs
amdomanska Sep 23, 2024
d6c4e57
change renderer name
amdomanska Sep 23, 2024
4ddeb62
merge up from develop for template changes
richard-jones Oct 23, 2024
4002cd5
Merge branch 'develop' into feature/2832_subject_tree_rendering_changes
richard-jones Oct 23, 2024
4f75ccb
merge up from develop
richard-jones Jan 29, 2025
d5ac6d2
final few tweaks to get subject classifier to behave correctly
richard-jones Jan 30, 2025
588f0b1
Merge branch 'develop' into feature/2832_subject_tree_rendering_changes
Steven-Eardley Feb 13, 2025
88fceec
Merge branch 'develop' into feature/2832_form_subject_browser
Steven-Eardley Feb 13, 2025
ba39b2d
Merge branch 'feature/2832_subject_tree_rendering_changes' into featu…
Steven-Eardley Feb 13, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use edges helper rather than the ternary operator
amdomanska committed Sep 3, 2024
commit cfacb3f2768d37a70615e9e86fcba3cea78d0e28
4 changes: 2 additions & 2 deletions portality/static/js/doaj.fieldrender.edges.js
Original file line number Diff line number Diff line change
@@ -367,8 +367,8 @@ $.extend(true, doaj, {
subjectBrowser: function (params) {
var tree = params.tree;
var hideEmpty = edges.getParam(params.hideEmpty, false);
var id = params.id ? params.id : "subject";
var category = params.category ? params.category : "facet";
var id = edges.getParam(params.id, "subject");
var category = edges.getParam(params.category, "facet");

return edges.newTreeBrowser({
id: id,
Loading