[#14] feat : 나라별 예약 최저가격 순으로 조회하기 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sss4920
approved these changes
Nov 27, 2023
|
|
||
|
|
||
| @Query("SELECT r, MIN(t.price) FROM Reservation r JOIN r.tickets t WHERE r.country = :country GROUP BY r ORDER BY MIN(t.price) ASC") | ||
| List<Object[]> findReservations(@Param("country") String country); |
There was a problem hiding this comment.
흠 저도 요렇게 되지않을까요..?! 라고 했던거라 같이 고민해봐용!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚩 관련 이슈
📋 구현 기능 명세
📌 PR Point
무슨 이유로 어떻게 코드를 변경했는지
어떤 부분에 리뷰어가 집중해야 하는지
이 부분에서 Object를 안쓰고 싶어 새로운 DTO까지 만들어서 해볼라했는데 타입이 안맞다는 에러가 떠서 어떻게 고치면 좋을지 고민이에요...
📸 결과물 스크린샷
{ "code": 200, "message": "항공권 페이지 조회 성공", "data": { "dateDto": { "startDate": "2023-11-13 월", "endDate": "2023-11-15 수" }, "airDto": [ { "reservationId": 4, "airName": "아시아나항공", "startTime": { "startTime": "9:10", "endTime": "11:40", "during": "2시간 30분" }, "endTime": { "startTime": "13:00", "endTime": "16:00", "during": "3시간 00분" }, "price": "467,000", "CO2": 28 }, { "reservationId": 1, "airName": "대한항공", "startTime": { "startTime": "13:15", "endTime": "16:05", "during": "2시간 50분" }, "endTime": { "startTime": "17:05", "endTime": "11:15", "during": "3시간 25분" }, "price": "467,100", "CO2": 21 }, { "reservationId": 5, "airName": "제주항공", "startTime": { "startTime": "10:05", "endTime": "12:45", "during": "2시간 40분" }, "endTime": { "startTime": "14:00", "endTime": "17:15", "during": "3시간 15분" }, "price": "467,100", "CO2": 25 }, { "reservationId": 6, "airName": "에어부산", "startTime": { "startTime": "8:35", "endTime": "11:15", "during": "2시간 40분" }, "endTime": { "startTime": "12:25", "endTime": "15:45", "during": "3시간 20분" }, "price": "467,100", "CO2": 24 }, { "reservationId": 7, "airName": "Peach", "startTime": { "startTime": "8:35", "endTime": "11:15", "during": "2시간 40분" }, "endTime": { "startTime": "12:25", "endTime": "15:45", "during": "3시간 20분" }, "price": "467,100", "CO2": 20 }, { "reservationId": 8, "airName": "ANA (전일본공수)", "startTime": { "startTime": "8:35", "endTime": "11:15", "during": "2시간 40분" }, "endTime": { "startTime": "13:00", "endTime": "16:00", "during": "3시간 00분" }, "price": "467,100", "CO2": 22 }, { "reservationId": 2, "airName": "에어서울", "startTime": { "startTime": "12:05", "endTime": "15:00", "during": "2시간 55분" }, "endTime": { "startTime": "15:55", "endTime": "19:10", "during": "2시간 40분" }, "price": "467,200", "CO2": 31 }, { "reservationId": 3, "airName": "진에어", "startTime": { "startTime": "8:35", "endTime": "11:15", "during": "2시간 40분" }, "endTime": { "startTime": "18:35", "endTime": "11:15", "during": "2시간 40분" }, "price": "467,300", "CO2": 27 } ] } }🛠️ 테스트
🚀 API Endpoint