feat(LinkCard & ServiceCard): correction clic sur la carte #3329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mintoo200
requested changes
Sep 18, 2024
src/client/components/features/ServiceCard/Card/ServiceCard.module.scss
Outdated
Show resolved
Hide resolved
src/client/components/features/ServiceCard/Card/ServiceCard.module.scss
Outdated
Show resolved
Hide resolved
src/client/components/features/ServiceCard/Card/ServiceCard.module.scss
Outdated
Show resolved
Hide resolved
src/client/components/features/ServiceCard/Card/ServiceCard.tsx
Outdated
Show resolved
Hide resolved
…dule.scss Co-authored-by: Gauthier Fiorentino <[email protected]>
…dule.scss Co-authored-by: Gauthier Fiorentino <[email protected]>
…dule.scss Co-authored-by: Gauthier Fiorentino <[email protected]>
Co-authored-by: Gauthier Fiorentino <[email protected]>
Co-authored-by: Gauthier Fiorentino <[email protected]>
Co-authored-by: Gauthier Fiorentino <[email protected]>
Co-authored-by: Gauthier Fiorentino <[email protected]>
sylviamoreno
force-pushed
the
feat/UNJ1S-1509-correction-clic-linkCard-serviceCard
branch
from
d36f603
to
5e33656
Compare
|
retours corrigés + tests @Mintoo200 si tu veux jeter un dernier coup d'oeil.... |
Mintoo200
requested changes
Sep 30, 2024
src/client/components/features/Engagement/Rechercher/RechercherMission.test.tsx
Show resolved
Hide resolved
src/client/components/features/Engagement/Rechercher/RechercherMission.test.tsx
Show resolved
Hide resolved
...features/FormationAlternance/Consulter/Statistiques/StatistiquesFormationAlternance.test.tsx
Outdated
Show resolved
Hide resolved
| const icon = useMemo(function () { | ||
| return <Icon name={isInternalLink ? 'arrow-right' : 'external-redirection'} />; | ||
| }, [isInternalLink]); | ||
| const linkTitle = !isInternalLink ? `${linkLabel} - nouvelle fenêtre` : 'En savoir plus'; |
There was a problem hiding this comment.
Mais du coup c'est toujours pas bon là, si ?
src/client/components/features/ServiceCard/Card/ServiceCard.tsx
Outdated
Show resolved
Hide resolved
Mintoo200
approved these changes
Oct 7, 2024
Mintoo200
deleted the
feat/UNJ1S-1509-correction-clic-linkCard-serviceCard
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.