Call updateMonitoringMetrics in ApplyLoggingPlugins
#2993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifenjoiner
force-pushed
the
metrics2
branch
from
4423e7f to
61b69d5
Compare
lifenjoiner
changed the title
updateMonitoringMetrics for all queriesupdateMonitoringMetrics following all ApplyLoggingPlugins
lifenjoiner
force-pushed
the
metrics2
branch
from
61b69d5 to
ea9728d
Compare
|
Would it make sense to call updateMonitoringMetrics() directly in ApplyLoggingPlugins ? |
lifenjoiner
changed the title
updateMonitoringMetrics following all ApplyLoggingPluginsupdateMonitoringMetrics in ApplyLoggingPlugins
Keep both results the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SERVER_TIMEOUT, FORWARD, DROP and etc. results, for example.