defer clientsCountDec() to prevent counter leak on potential panic #2991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifenjoiner
reviewed
Sep 25, 2025
| return err | ||
| } | ||
|
|
||
| if !plugin.proxy.clientsCountInc() { |
There was a problem hiding this comment.
Step into this. The counter will not increase, if reaches the up bound. AI without review?
There was a problem hiding this comment.
I don't see how the upper bound is directly relevant to the change here. It's about processIncomingQuery and how if a panic occurs somewhere in that, the counter is never from deincremented. If that happens over and over, the server will be inoperable after the never-deincremented variable reaches the limit of clientscount (yes, the upper bound)
There was a problem hiding this comment.
If panic, won't the program crash?
Strange things happened in my mind about this defer. 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shouldn't actually happen, but I think it's worth it just in case.
P.S: this is my last PR:)