[issue-3597] Add explicit SPDM_MAX_OPAQUE_DATA_SIZE check in responder FINISH and PSK_FINISH parsers#3657
Open
czwolak wants to merge 1 commit into
Open
Conversation
…r FINISH and PSK_FINISH parsers Mirror the explicit opaque-length max-bound check already present in the requester-side parsers (libspdm_req_finish.c and libspdm_req_psk_finish.c) to the corresponding responder-side parsers. Reject requests where req_opaque_data_size > SPDM_MAX_OPAQUE_DATA_SIZE with INVALID_REQUEST before the downstream size-consistency check, making validation symmetric across all four paths. Signed-off-by: Cezary Zwolak <cezary.zwolak@intel.com>
alistair23
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3597
Mirror the explicit opaque-length max-bound check that already exists in the requester-side parsers to the corresponding responder-side parsers.
Existing pattern (requester side):
libspdm_req_finish.cline 600:if (opaque_data_size > SPDM_MAX_OPAQUE_DATA_SIZE)→ rejectlibspdm_req_psk_finish.cline 292: same checkAdded (responder side):
libspdm_rsp_finish_rsp.c: addif (req_opaque_data_size > SPDM_MAX_OPAQUE_DATA_SIZE)before the size-consistency checklibspdm_rsp_psk_finish_rsp.c: same checkBoth reject with
SPDM_ERROR_CODE_INVALID_REQUEST, consistent with the existing error-response pattern in those functions.This makes opaque-length validation symmetric across all four FINISH/PSK_FINISH request and response parsing paths.
Signed-off-by: Cezary Zwolak cezary.zwolak@intel.com