Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add initial 1.4 wip #2957

Open
wants to merge 43 commits into
base: 1.4WIP
Choose a base branch
from
Open

add initial 1.4 wip #2957

wants to merge 43 commits into from

Conversation

jyao1
Copy link
Member

@jyao1 jyao1 commented Jan 15, 2025

No description provided.

@jyao1
1.4 Add PQC oqs submodule.
1c8086e 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1 jyao1 requested a review from steven-bellock as a code owner January 15, 2025 04:17
jyao1 added 27 commits January 15, 2025 12:41
@jyao1
1.4 add PQC oqslib build.
3b4a720 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 add version definition
9e81ee3 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 add version to context init.
856fc44 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 add PQC gen_pqc_key program to generate PQC DSA sample key.
5a7aad1 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add PQC test DSA sample keys.
17d298d 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add PQC test_crypt_pqc to test PQC algo.
0638b6e 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add PQC to HAL cryptlib.h
11e4687 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 add PQC to HAL (req)asymsignlib.h
db14eb1 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add PQC to HAL csr/setcert lib.
acca92b 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add PQC to HAL key_pair_info lib
69c7dd2 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add PQC pqcryptlib_oqs
2dbf287 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add PQC pqccryptlib_null
7674190 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add PQC to spdm_device_secret_lib_sample
353bb06 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add PQC to spdm_device_secret_lib_null
1b3ea11 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add PQC oqslib and pqccryptlib to CMakeLists of unit_tests
5308b59 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add PQC oqslib, pqccryptlib_oqs/null and test app to build CMakeL…
56e29a7 
…ists.

Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add PQC to SPDM definition
b731743 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 PQC enlarge LIBSPDM_MAX_CERT_CHAIN_SIZE in spdm_lib_config.
6b040b9 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 add PQC algorithm in configuration
a6d2b66 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add PQC algorithm in spdm_context
0c42770 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add PQC to spdm_crypt_lib.
7926d2e 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 add PQC to spdm_crypt_ext_lib
067c450 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add PQC to spdm_secured_message_lib
d7d4c66 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add PQC to ALGORITHM request/response.
50da625 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add PQC to KEY_EXCHANGE request/response
bf4281a 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add PQC to FINISH request/response.
fbc10c2 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add PQC to (enc) CHALLENGE request/response
79255b9 
Signed-off-by: Jiewen Yao <[email protected]>
jyao1 added 13 commits January 15, 2025 12:41
@jyao1
1.4 Add PQC to MEASUREMENT request/response.
414c22e 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add PQC to (enc) GET_CERT request
daf398c 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add PQC to SET_CERT response.
5fa4a14 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add PQC to CSR response.
51d2d85 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add PQC to GET/SET_KEY_PAIR_INFO requester/response.
b2287b2 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add capability to SPDM header
37a5a26 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add check to CAPABILITY request/response
3960473 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add LargeCertChain to SPDM header.
a90a3cc 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add LargeCertChain to (enc) CERTIFICATE request/response.
635265b 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Add LargeCertChain to SET_CERTIFICATE response.
84ea365 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Change CertChain Header to use UINT32 Length in SPDM definition.
09c6a43 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Change CertChain Header to use UINT32 Length in spdm_device_secre…
b0873a7 
…t_lib_sample

Signed-off-by: Jiewen Yao <[email protected]>
@jyao1
1.4 Change CertChain Header to use UINT32 Length in Unit Test
73b6457 
Signed-off-by: Jiewen Yao <[email protected]>
@jyao1 jyao1 force-pushed the 1.4WIP branch 4 times, most recently from dcf674e to c0a8bc7 Compare January 15, 2025 05:14
steven-bellock
steven-bellock reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@steven-bellock steven-bellock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to go over how this should be split up into smaller commits and pull requests.

include/hal/library/cryptlib/cryptlib_cert_pqc.h
@@ -0,0 +1,31 @@
/**
* Copyright Notice:
* Copyright 2021-2024 DMTF. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All new files need Copyright 2025 DMTF.

Copy link
Member Author

@jyao1 jyao1 Jan 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question: When do you think we will merge into main?

I prefer to change that when we merge to main.

It is meaningless to change it to 2025 now, and change again if we merge in 2026.

CMakeLists.txt
@@ -939,6 +939,10 @@ else()
add_subdirectory(os_stub/spdm_device_secret_lib_null)
add_subdirectory(os_stub/spdm_cert_verify_callback_sample)

add_subdirectory(os_stub/oqslib)
add_subdirectory(os_stub/pqccryptlib_oqs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pqccryptlib_oqs -> cryptlib_liboqs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add pqc prefix - pqccryptlib_liboqs, because it is not parallel to cryptlib_openssl or cryptlib_mbedtls.

README.md Outdated
@@ -171,6 +174,8 @@ For other architectures, refer to [build](https://github.com/DMTF/libspdm/blob/m

2) [OpenSSL](https://www.openssl.org) as cryptography library. Version 3.0.14.

3) [OQS](https://github.com/open-quantum-safe/liboqs) as PQC cryptography library. Version 0.12.0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended to be a long-lived cryptography library, or just one that will be used for development and eventually MbedTLS and OpenSSL will support PQC in production?

Copy link
Member Author

@jyao1 jyao1 Jan 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say: If MbedTLS and OpenSSL support PQC in production, we can remove OQS for sure.

But before that, we have to use OQS for development. And I don't know WHEN the mbedTLS or OpenSSL will be ready.

If there is worry about quality, we can clarify, something like: "please read the OQS release note, to understand the production level."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-bellock steven-bellock steven-bellock left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jyao1 @steven-bellock