Skip to content

Ported to OCCT 7.8.x #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2025
Merged

Ported to OCCT 7.8.x #1063

merged 3 commits into from
Apr 23, 2025

Conversation

rainman110
Copy link
Collaborator

@rainman110 rainman110 commented Feb 26, 2025

Description

These small changes port TiGL to OpenCASCADE 7.8.

Most changes are cosmetic ones. Only for the hash computation, we cannot use anymore a hash maximum
value, which was probably never a good idea, but it will change the resulting hashes.

This should be no problem, since the hashes are mostly used internally.

How Has This Been Tested?

I just compiled and ran TiGL Viewer successfully.

I hope that the unit test will be successful ... keeping fingers crossed 😏

Screenshots, that help to understand the changes(if applicable):

Checklist:

Task Finished Reviewer Approved
At least one test for the new functionality was added.
  • yes
  • does not apply
  • OK
New classes have been added to the Python interface.
  • yes
  • does not apply
  • OK
The code is properly documented with doxygen docstrings
  • yes
  • does not apply
  • OK
Changes are documented at the top of ChangeLog.md
  • yes
  • does not apply
  • OK

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.52%. Comparing base (aaae62f) to head (edf49c8).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/common/tiglcommonfunctions.cpp 66.66% 1 Missing ⚠️
src/geometry/CTiglIntersectionCalculation.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1063   +/-   ##
=======================================
  Coverage   69.52%   69.52%           
=======================================
  Files         301      301           
  Lines       26949    26951    +2     
=======================================
+ Hits        18735    18737    +2     
  Misses       8214     8214           
Flag Coverage Δ
unittests 69.52% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/common/tiglcommonfunctions.h 100.00% <ø> (ø)
src/geometry/CTiglBSplineFit.cpp 92.02% <ø> (ø)
src/imports/CTiglStepReader.cpp 90.00% <100.00%> (ø)
src/common/tiglcommonfunctions.cpp 78.25% <66.66%> (+0.03%) ⬆️
src/geometry/CTiglIntersectionCalculation.cpp 88.09% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rainman110 rainman110 changed the title Try to port to occt 7.8.x series Ported to OCCT 7.8.x Mar 23, 2025
@rainman110 rainman110 marked this pull request as ready for review March 23, 2025 22:37
Copy link
Contributor

@joergbrech joergbrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 💐

@joergbrech joergbrech merged commit c320272 into master Apr 23, 2025
16 of 17 checks passed
@joergbrech joergbrech deleted the port_to_occt_78x branch April 23, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants