no update is also returns success [Test Sandro, do not merge or edit] #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
yes, but this way you would be able to forget to update the version number, because the test would pass even though you have not updated the version number. This way we enforce that every PR into main is at least a Patch release. |
Davknapp
assigned
Davknapp and
sandro-elsweijer and unassigned
sandro-elsweijer and
Davknapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since not updating the version number if the commit does not contain the keyword is intended behavior I would suggest it to return a successful operation. This way the test only fails if a "real" error happens. Furthermore github would always show an ❌ for a PR even if all other tests pass. Only the version update commit would get a ✅