Update VC/SA #185
Closed
Update VC/SA #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added CPlaneBanner, CPlaneBanners, CPlaneTrail, CPlaneTrails for VC, and RwTextureRead/HasModelLoaded for SA
New events for 3D things rendering
MiranDMC
reviewed
May 13, 2025
| @@ -21,6 +21,9 @@ namespace plugin { | |||
| namespace Events { | |||
| #ifdef GTASA | |||
| static CdeclEvent <AddressList<0x53E293, H_CALL>, PRIORITY_AFTER, ArgPickNone, void()> drawingEvent; | |||
| static CdeclEvent <AddressList<0x726AD0, H_CALL>, PRIORITY_AFTER, ArgPickNone, void()> RenderSpecialFxEvent; | |||
| static ThiscallEvent <AddressList<0x53E175, H_CALL>, PRIORITY_AFTER, ArgPickNone, void()> RenderEffectsEvent; | |||
| static CdeclEvent <AddressList<0x717150, H_CALL>, PRIORITY_AFTER, ArgPickNone, void()> movingThingsEvent; | |||
There was a problem hiding this comment.
White characters inconsistent with rest of the file.
MiranDMC
reviewed
May 13, 2025
| @@ -134,6 +134,7 @@ class PLUGIN_API CStreaming { | |||
| //! return modelIndex | |||
| SUPPORTED_10US static int GetNextFileOnCd(int pos, bool bNotPriority); | |||
| SUPPORTED_10US static bool HasSpecialCharLoaded(int slot); | |||
| SUPPORTED_10US static bool HasModelLoaded(int32_t id) { return ms_aInfoForModel[id].m_nLoadState == LOADSTATE_LOADED; } | |||
There was a problem hiding this comment.
Why just 1.0US?
Why adding just to one game from trilogy?
MiranDMC
reviewed
May 13, 2025
| public: | ||
| static void Update(void); | ||
| static void RegisterPoint(CVector pos, uint32_t trailIndex); | ||
| }; |
There was a problem hiding this comment.
You are unable to keep consistent coding style even with yourself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CPlaneBanner, CPlaneBanners, CPlaneTrail, CPlaneTrails for VC, and RwTextureRead/HasModelLoaded for SA