Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editeur de texte riche #2 #1018

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Editeur de texte riche #2 #1018

wants to merge 16 commits into from

Conversation

hissalht
Copy link
Collaborator

closes #982

Avant de merger la pull request, s’assurer que :

  • Les checks GitHub passent (lint...).
  • Les tests Cypress ont été lancés en local (dans le cas d’une correction de bug ou d’une nouvelle fonctionnalité).

@hissalht hissalht temporarily deployed to ara-rich-text-editor-pa-xrzwim March 21, 2025 15:42 Inactive
@hissalht hissalht temporarily deployed to ara-rich-text-editor-pa-xrzwim March 21, 2025 17:38 Inactive
@bellangerq bellangerq changed the title use tiptap for audit comments Editeur de texte riche #2 Mar 21, 2025
@hissalht hissalht temporarily deployed to ara-rich-text-editor-pa-xrzwim March 26, 2025 10:07 Inactive
@hissalht hissalht temporarily deployed to ara-rich-text-editor-pa-xrzwim March 26, 2025 10:33 Inactive
@hissalht hissalht temporarily deployed to ara-rich-text-editor-pa-xrzwim March 26, 2025 10:43 Inactive
@bellangerq
Copy link
Collaborator

bellangerq commented Mar 26, 2025 •
edited
Loading

  • Ajouter un état désactivé (disable les boutons + editable = false)
  • Cacher le label "Erreur et recommandation"
  • Simplifier le aria-describedby
  •  Mettre un id unique sur la description du champs
  •  Problème de style sur les listes à puces ordonnées (--ol-content: "", counter-reset: "")
  • Rendre le focus plus joli

@hissalht hissalht temporarily deployed to ara-rich-text-editor-pa-xrzwim March 26, 2025 16:02 Inactive
@hissalht hissalht temporarily deployed to ara-rich-text-editor-pa-xrzwim March 26, 2025 16:14 Inactive
@bellangerq bellangerq marked this pull request as ready for review March 26, 2025 16:18
@bellangerq
Copy link
Collaborator

@hissalht hissalht temporarily deployed to ara-rich-text-editor-pa-xrzwim April 9, 2025 12:13 Inactive
@bellangerq bellangerq force-pushed the rich-text-editor-part-two branch from 133be8f to 217ee4c Compare April 9, 2025 12:30
@benoitdequick
Copy link
Contributor

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitdequick benoitdequick benoitdequick approved these changes

@yaaax yaaax Awaiting requested review from yaaax

@AdrienMuzyczka AdrienMuzyczka Awaiting requested review from AdrienMuzyczka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

L'intégration de l'éditeur dans la modale des notes et dans les commentaires de critères
3 participants
@hissalht @bellangerq @benoitdequick