feat: lock file while read, write and refresh token #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natthan-pigoux
force-pushed
the
feat/lock_refresh_token
branch
from
a90eb70
to
a6119f9
Compare
chaen
force-pushed
the
feat/lock_refresh_token
branch
from
7315d77
to
e259927
Compare
natthan-pigoux
force-pushed
the
feat/lock_refresh_token
branch
from
276db27
to
523cf68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #133
Tests can be performed on
read/write_credentials, and the client (probably simpler if we do it throughget_tokendirectly). Test cases:read/write_credentialsandget_token) multiple processes attempting to read or write to the credentials file simultaneously.read/write_credentials) credentials file is missing, empty, invalid.get_token) token exists and is valid, credentials file is missing, empty, invalid, token needs to be refreshed, refresh token valid/invalid.