Skip to content

Commit

Permalink
Merge pull request #7857 from chaen/v8.0_fix_fts3Agentcondition
Browse files Browse the repository at this point in the history
fix (FTSAgent): correct condition for return type
  • Loading branch information
chrisburr authored Oct 29, 2024
2 parents 91644dc + a14849c commit 53c67a7
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/DIRAC/DataManagementSystem/Agent/FTS3Agent.py
Original file line number Diff line number Diff line change
Expand Up @@ -288,14 +288,15 @@ def _monitorJobCallback(returnedValue):
:param returnedValue: value returned by the _monitorJob method
(ftsJob, standard dirac return struct)
"""
if not isinstance(returnedValue, tuple) or len(returnedValue) != 2:
if isinstance(returnedValue, tuple) and len(returnedValue) == 2:
ftsJob, res = returnedValue
log = gLogger.getLocalSubLogger(f"_monitorJobCallback/{ftsJob.jobID}")
if not res["OK"]:
log.error("Error updating job status", res)
else:
log.debug("Successfully updated job status")
else:
log = gLogger.getLocalSubLogger("_monitorJobCallback")
log.error("Invalid return value when monitoring job", f"{returnedValue!r}")

def monitorJobsLoop(self):
Expand Down Expand Up @@ -382,6 +383,7 @@ def _treatOperationCallback(returnedValue):
else:
log.debug("Successfully treated operation")
else:
log = gLogger.getLocalSubLogger("_treatOperationCallback")
log.error("Invalid return value when treating operation", f"{returnedValue!r}")

def _treatOperation(self, operation):
Expand Down

0 comments on commit 53c67a7

Please sign in to comment.