Support 21095 Create OpenAPI 3 file for ObjectUpload #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xuemeigan
commented
Dec 16, 2020
xuemeigan
commented
- Add object-upload.yml file and link it to the object-store-api.yml
- Add object-upload.yml file and link it to the object-store-api.yml
Jkeyuk
suggested changes
Dec 18, 2020
| summary: Upload a file to minio bucket | ||
| operationId: uploadFile | ||
| description: Upload a file to minio bucket | ||
| responses: |
There was a problem hiding this comment.
We need to define the bucket in the parameters
parameters:
- name: bucket
in: path
description: bucket of the file
required: true
schema:
type: string
There was a problem hiding this comment.
If you look at here : https://github.com/DINA-Web/object-store-specs/blob/Support--21095--Create-OpenAPI-3-file-for-ObjectUpload/schema/object-upload.yml#L85
The parameter is described in request body of form-data
|
Just one small thing missing and we should be good |
- Add bucket in parameter section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.