Sqlalchemy #240
Merged
Sqlalchemy #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reate correct order
…ate correct order
Merged
Co-authored-by: Dion Häfner <[email protected]>
Co-authored-by: Dion Häfner <[email protected]>
Apparently pytest creates some LocalPath objects, which are not caught in isinstance(..., Path)
Sqlalchemy compositional
dionhaefner
approved these changes
Feb 21, 2022
|
@nickeopti we good to go? |
nickeopti
commented
Feb 21, 2022
|
Yes, I believe this is mergeable! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft, WIP, PR. Just made to keep track of things, and for the tests to run. Can be ignored for now.Edit: PR for improving the structure and codebase of the drivers. Was originally just for replacing the database specific code with a more general SQLAlchemy implementation. But has now also turned into a bigger, more general refactor of the entire driver code.