Build action

[tombueng]

Please add a build action so we can download your extensoin from github.

[tombueng]

Needs to be adjusted!

[DGuhr]

Shuoldn't this be called 21?

[DGuhr]

@tombueng Thank you for your contribution first of all. Unexpected :)
That said: The build in this PR is using jdk 21. This opens up a question: The reason why I did not add a build action in the first place (apart from me being lazy) is, that you have to build it yourself with the java version matching your applications' java version. So, when you run a JDK 11 java app/otel agent, but build the extension with JDK 21, it won't work - see my notes in the README. So i think if we want to add a build/release step here, we should have at least a matrix build for, say, last three JDK LTE versions + current one, right? So it's not that simple. I'm happy to hear your thoughts about this, not at all against adding it, but if we add it, it should be right not just for one use case, but in general.

edit: added #4 as issue for this.

[tombueng]

SureAm 30.10.2024 13:34 schrieb Dominik Guhr ***@***.***>: @DGuhr commented on this pull request. In .github/workflows/maven-publish.yml:

+ release:

+ types: [created] + +jobs: + build: + + runs-on: ubuntu-latest + permissions: + contents: read + packages: write + defaults: + run: + working-directory: otel-javaagent-spring-extension + steps: + - uses: ***@***.*** + - name: Set up JDK 11 Shuoldn't this be called 21? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>

[tombueng]

Not sure, but compiling with 21 for 11 should work. Will elaborate next days.Am 30.10.2024 13:38 schrieb Dominik Guhr ***@***.***>: @tombueng Thank you for your contribution first of all. Unexpected :) That said: The build is using jdk 21. This opens up a question: The reason why I did not add a build action in the first place (apart from me being lazy) is, that you have to build it yourself with the java version matching your applications' java version. So, when you run a JDK 11 java app, but build the extension with jdk 21, it won't work - see my notes in the README. So i think if we want to add a build/release step here, we should have at least a matrix build for, say, last three JDK LTE versions + current one, right? So it's not that simple. I'm happy to hear your thoughts about this, not at all against adding it, but if we add it, it should be right not just for one use case, but in general. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>