Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a build/release step #4

Open
DGuhr opened this issue Oct 30, 2024 · 0 comments · May be fixed by #3
Open

Add a build/release step #4

DGuhr opened this issue Oct 30, 2024 · 0 comments · May be fixed by #3

Comments

@DGuhr
Copy link
Owner

DGuhr commented Oct 30, 2024

As I unexpectedly got a PR for this in #3 I think we should open up an issue for that to have it the normal way.

Text from my pr comment:

The build in this PR is using JDK 21. This opens up a question: The reason why I did not add a build action in the first place (apart from me being lazy) is, that you have to build it yourself with the java version matching your applications' java version. So, when you run a JDK 11 java app, but build the extension with jdk 21, it won't work - see my notes in the README. So i think if we want to add a build/release step here, we should have at least a matrix build for, say, last three JDK LTE versions + current one, right? So it's not that simple. I'm happy to hear your thoughts about this, not at all against adding it, but if we add it, it should be right not just for one use case, but in general.

@DGuhr DGuhr linked a pull request Oct 30, 2024 that will close this issue
@DGuhr DGuhr linked a pull request Oct 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant