You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The build in this PR is using JDK 21. This opens up a question: The reason why I did not add a build action in the first place (apart from me being lazy) is, that you have to build it yourself with the java version matching your applications' java version. So, when you run a JDK 11 java app, but build the extension with jdk 21, it won't work - see my notes in the README. So i think if we want to add a build/release step here, we should have at least a matrix build for, say, last three JDK LTE versions + current one, right? So it's not that simple. I'm happy to hear your thoughts about this, not at all against adding it, but if we add it, it should be right not just for one use case, but in general.
The text was updated successfully, but these errors were encountered:
As I unexpectedly got a PR for this in #3 I think we should open up an issue for that to have it the normal way.
Text from my pr comment:
The build in this PR is using JDK 21. This opens up a question: The reason why I did not add a build action in the first place (apart from me being lazy) is, that you have to build it yourself with the java version matching your applications' java version. So, when you run a JDK 11 java app, but build the extension with jdk 21, it won't work - see my notes in the README. So i think if we want to add a build/release step here, we should have at least a matrix build for, say, last three JDK LTE versions + current one, right? So it's not that simple. I'm happy to hear your thoughts about this, not at all against adding it, but if we add it, it should be right not just for one use case, but in general.
The text was updated successfully, but these errors were encountered: