Skip to content

mod-manager.lua: do not except on missing mod metadata #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.txt
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ Template for new versions:
## New Features

## Fixes
- `gui/mod-manager`: gracefully handle mods with missing or broken ``info.txt`` files

## Misc Improvements

Expand Down
3 changes: 2 additions & 1 deletion gui/mod-manager.lua
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,8 @@ function ModlistWindow:refresh_list()
local choices = {}
for idx,mod in ipairs(scriptmanager.get_active_mods()) do
if not include_vanilla and mod.vanilla then goto continue end
local steam_id = scriptmanager.get_mod_info_metadata(mod.path, 'STEAM_FILE_ID').STEAM_FILE_ID
local metadata = scriptmanager.get_mod_info_metadata(mod.path, 'STEAM_FILE_ID')
local steam_id = metadata and metadata.STEAM_FILE_ID or nil
local url = steam_id and (': https://steamcommunity.com/sharedfiles/filedetails/?id=%s'):format(steam_id) or ''
table.insert(choices, {
text={
Expand Down