Send start date to TRS when completing inductions #191
+76
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They should be Passed and Failed, not Pass and Fail Co-authored-by: gunndabad <[email protected]>
This is required by the TRS API.
It's safer for us to pass Ruby date and time objects into the API client and for it to convert them into strings in the format the API expects. Fixes DFE-Digital/register-ects-project-board#617
|
Review app deployed to https://cpd-ec2-review-191-web.test.teacherservices.cloud |
peteryates
force-pushed
the
send-start-date-on-induction-completion
branch
from
a4ae4ff to
a9ce188
Compare
edujackedu
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a few small changes, I suggest reviewing commit-by commit.