Refine content on successful release page #185
Merged
+116
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://cpd-ec2-review-185-web.test.teacherservices.cloud |
peteryates
force-pushed
the
Refine-content-on-successful-release-page
branch
from
c1ac807 to
e3dcc7c
Compare
We will soon be extending this to find former teachers too so we can make the release/pass/fail journeys more robust.
This works like #current but returns teachers who were associated with the appropriate body in the past.
peteryates
force-pushed
the
Refine-content-on-successful-release-page
branch
from
e3dcc7c to
4f765f6
Compare
edujackedu
approved these changes
Feb 12, 2025
emily-prudence-dfe
approved these changes
Feb 12, 2025
peteryates
approved these changes
Feb 13, 2025
|
Review app ECF2 deployed to https://ec2-review-185-web.test.teacherservices.cloud was deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content refined to bring in line with 'claim success page' and changed button to link.
We agree that design for this could be better, including pass and fail journeys. MVP+1 would be to remove these success pages and show ECT record with relevant notification banner (https://design-system.service.gov.uk/components/notification-banner/) confirming the users action.
Before and after screenshots:
Bug ticket: https://github.com/DFE-Digital/register-ects-project-board/issues/1227