Add page for ECT personal and training details #180
Conversation
peterdavidhamilton
commented
Feb 12, 2025
peterdavidhamilton
commented
- ECT show action template
- view helpers refactor
- view helpers refactor
peterdavidhamilton
temporarily deployed
to
review
GitHub Actions
Inactive
|
Review app deployed to https://cpd-ec2-review-180-web.test.teacherservices.cloud |
| def ect_status(_ect) | ||
| govuk_tag(text: 'In progress', colour: 'green') | ||
| end |
There was a problem hiding this comment.
We should be explicit about the kind of status we're talking about here. Training status, induction status, etc.
There was a problem hiding this comment.
We haven't decided yet. So we can either leave as is and define later, or remove if you think it'll make it less confusing?
There was a problem hiding this comment.
Ah that's fine, so long as it's placeholder!
There was a problem hiding this comment.
Following a Slack discussion I have done some follow-up work in a separate branch that makes this placeholder more visible.
| caption_size: 'l', | ||
| ) | ||
| %> | ||
| <h2 class='govuk-heading-m'>Personal details</h2> |
There was a problem hiding this comment.
| <h2 class='govuk-heading-m'>Personal details</h2> | |
| <h2 class='govuk-heading-m'>ECT details</h2> |
| ) | ||
| %> | ||
| <%= | ||
| govuk_summary_card(title: 'Current training details') do |card| |
There was a problem hiding this comment.
Let's stick with this for now, but still not sure ABs are strictly training details
There was a problem hiding this comment.
| academic_year = FactoryBot.create(:academic_year) | ||
| lead_provider = FactoryBot.create(:lead_provider, name: 'Ambition institute') | ||
| delivery_partner = FactoryBot.create(:delivery_partner) | ||
| provider_partnership = FactoryBot.create(:provider_partnership, lead_provider:, delivery_partner:, academic_year:) | ||
| appropriate_body = FactoryBot.create(:appropriate_body, name: 'Alpha Teaching School Hub') | ||
|
|
||
| FactoryBot.create(:training_period, :active, :for_ect, provider_partnership:, | ||
| ect_at_school_period: current_ect_period, | ||
| started_on: current_ect_period.started_on) | ||
|
|
||
| FactoryBot.create(:induction_period, :active, teacher:, appropriate_body:) |
There was a problem hiding this comment.
Do we need to create these records or will building work?
There was a problem hiding this comment.
I will find out
