[CPDNPQ-1362] Update provider names #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://npq-registration-review-1383-web.test.teacherservices.cloud/ |
TBenedyk
force-pushed
the
CPDNPQ-1362_update_provider_names
branch
from
27869a5
to
29e0042
Compare
TBenedyk
changed the title
cwrw
reviewed
May 20, 2024
| "Church of England" => "79cb41ca-cb6d-405c-b52c-b6f7c752388d", | ||
| "Education Development Trust" => "21e61f53-9b34-4384-a8f5-d8224dbf946d", | ||
| "LLSE" => "230e67c0-071a-4a48-9673-9d043d456281", | ||
| "National Institute of Teaching" => "3ec607f2-7a3a-421f-9f1a-9aca8a634aeb", | ||
| "School-Led Network" => "bc5e4e37-1d64-4149-a06b-ad10d3c55fd0", | ||
| "Teacher Development Trust" => "30fd937e-b93c-4f81-8fff-3c27544193f1", | ||
| "Teach First" => "a02ae582-f939-462f-90bc-cebf20fa8473", | ||
| "UCL Institute of Education" => "ef687b3d-c1c0-4566-a295-16d6fa5d0fa7", | ||
| "University College London (UCL) Institute of Education" => "ef687b3d-c1c0-4566-a295-16d6fa5d0fa7", |
There was a problem hiding this comment.
this change is interesting, I was hoping we could keep it consistent with ECF which is UCL Institute of Education, unless we plan to change it there as well?
There was a problem hiding this comment.
@cwrw and I discussed this and it was decided to accept the name inconsistency in NPQ/ECF for now. It can be updated after the NPQ separation MVP work is completed.
leandroalemao
previously requested changes
May 21, 2024
cwrw
approved these changes
Jul 17, 2024
TBenedyk
force-pushed
the
CPDNPQ-1362_update_provider_names
branch
from
29abbf1
to
551a175
Compare
ethax-ross
pushed a commit
that referenced
this pull request
Jul 19, 2024
* [cpdnpq-1362] updated lead provider names * [cpdnpq-1362] appeased rubocop * fixed schema * [cpdnpq-1362] fixing specs * [cpdnpq-1362] appeased rubocop * [cpdnpq-1362] readded migration * [CPDNPQ-1362] updated data migration * [CPDNPQ-1362] appeased the rubocop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Ticket: https://dfedigital.atlassian.net/browse/CPDNPQ-1704
Ensure provider names are consistent throughout the service. Using this phrasing: