Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linting to cypress tests #628

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Add linting to cypress tests #628

merged 3 commits into from
Nov 25, 2024

Conversation

dynamictulip
Copy link
Collaborator

@dynamictulip dynamictulip commented Nov 25, 2024 •
edited
Loading

Add linting to cypress tests to enable fast feedback of problems with TypeScript

Task 190074: Add linting

Changes

  • Add linting to cypress tests
  • Fix linting issues in core cypress files
  • Updated linting docs

Checklist

  • Pull request attached to the appropriate user story in Azure DevOps
    ADR decision log updated (if needed)
    Release notes added to CHANGELOG.md
  • Testing complete - all manual and automated tests pass

@dynamictulip dynamictulip changed the base branch from main to level-2-nav-feature November 25, 2024 09:51
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

CMurrell148
CMurrell148 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@CMurrell148 CMurrell148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Sara! Thankyou for adding this!

@dynamictulip dynamictulip merged commit 561c025 into level-2-nav-feature Nov 25, 2024
11 checks passed
@dynamictulip dynamictulip deleted the level-2-nav/add-linting branch November 25, 2024 13:17
@dynamictulip dynamictulip mentioned this pull request Nov 28, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dneed-nimble dneed-nimble dneed-nimble approved these changes

@CMurrell148 CMurrell148 CMurrell148 approved these changes

@nwarms nwarms Awaiting requested review from nwarms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dynamictulip @dneed-nimble @CMurrell148