Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Azure Linux base image #618

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Switch to Azure Linux base image #618

merged 1 commit into from
Dec 11, 2024

Conversation

DrizzlyOwl
Copy link
Collaborator

@DrizzlyOwl DrizzlyOwl commented Nov 15, 2024 •
edited
Loading

  • Reduces the overall final image size by using Azure Linux
  • Offers maximum compatibility with Azure infrastructure
  • Uses arbitrary user instead of 'root'
  • Supported by Microsoft

I have also split the SQL Tools bit into it's own stage so it's cached better

https://github.com/dotnet/dotnet-docker/blob/main/documentation/azurelinux.md#azure-linux

@DrizzlyOwl DrizzlyOwl marked this pull request as ready for review November 15, 2024 15:33
dynamictulip
dynamictulip reviewed Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@dynamictulip dynamictulip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exciting, looking forward to catching up about it on Monday

docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
@DrizzlyOwl
Switch to Azure Linux base image
71d7ca2 
- Reduces the overall final image size by using Azure Linux
- Offers maximum compatibility with Azure infrastructure
- Uses arbitrary user instead of 'root'
- Supported by Microsoft
@DrizzlyOwl DrizzlyOwl enabled auto-merge December 11, 2024 14:09
@DrizzlyOwl DrizzlyOwl merged commit 67abd69 into main Dec 11, 2024
3 checks passed
@DrizzlyOwl DrizzlyOwl deleted the docker/azurelinux branch December 11, 2024 14:10
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dynamictulip dynamictulip dynamictulip approved these changes

@Stretch96 Stretch96 Stretch96 approved these changes

@dneed-nimble dneed-nimble Awaiting requested review from dneed-nimble

@nwarms nwarms Awaiting requested review from nwarms

Assignees

@dynamictulip dynamictulip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DrizzlyOwl @dynamictulip @Stretch96