-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[609] enabling task: add route for accessing recruitment cycle timetables as html or json #10345
Open
elceebee
wants to merge
1
commit into
main
Choose a base branch
from
609-enabling-task-cycle-end-point-for-reverting-to-production
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[609] enabling task: add route for accessing recruitment cycle timetables as html or json #10345
elceebee
wants to merge
1
commit into
main
from
609-enabling-task-cycle-end-point-for-reverting-to-production
+265
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0e43cc3
to
1027375
Compare
1027375
to
afdcc91
Compare
CatalinVoineag
approved these changes
Feb 6, 2025
Dev tested the endpoints on review, with json and HTML format |
dcyoung-dev
reviewed
Feb 6, 2025
app/controllers/publications/recruitment_cycle_timetables_controller.rb
Outdated
Show resolved
Hide resolved
app/controllers/publications/recruitment_cycle_timetables_controller.rb
Outdated
Show resolved
Hide resolved
app/controllers/publications/recruitment_cycle_timetables_controller.rb
Outdated
Show resolved
Hide resolved
app/controllers/publications/recruitment_cycle_timetables_controller.rb
Outdated
Show resolved
Hide resolved
app/views/publications/recruitment_cycle_timetables/_timetable_card.html.erb
Outdated
Show resolved
Hide resolved
afdcc91
to
bc1d37f
Compare
bc1d37f
to
97c5f8a
Compare
5fc6de1
to
9de20e7
Compare
9de20e7
to
563938b
Compare
563938b
to
1fd18e9
Compare
1fd18e9
to
937c2a0
Compare
dcyoung-dev
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! These endpoints will be great for the Reference Data maintainers to auto-generate the cycle timetables 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is an enabling task for using the RecruitmentCycleTimetable model in the cycle switcher. In order to 'switch back to production dates', we need to be able to get the production dates. The easiest way to do that is to expose them as json in a public page.
There is also an html rendering for reference
Changes proposed in this pull request
Endpoint for rendering all or one recruitment cycle timetable
Guidance to review
Check the following end points in the review app:
publications/recruitment-cycle-timetables?format=json
publications/recruitment-cycle-timetables/current?format=json
publications/recruitment-cycle-timetables/an-invalid-year-like-2018?format=json
publications/recruitment-cycle-timetables/2023?format=json
And then all again, but without the
format=json
param to see the html responseThings to check