Skip to content

fix: add fixed French translation & edit buttons on home page #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kunfang98927
Copy link
Contributor

@kunfang98927 kunfang98927 commented Feb 20, 2025

Resolves: #169

- fix #167 500 server error;
- add fixed French translation in some place;
- edit two buttons on the home page mentioned in #169;

Ref: #167 #169
@kunfang98927 kunfang98927 changed the title fix: add fixed French translation & fix 500 server issue fix: add fixed French translation & edit buttons on home page Feb 21, 2025
@dchiller
Copy link
Contributor

dchiller commented Feb 21, 2025

I think this approach to the problem is going to be unworkable down the road. I think much of what we are translating manually here (the nav buttons, the pagination options, etc) needs to be translated by the google translate widget...we are not going to do if/then statements for every language we support, right?

@kunfang98927
Copy link
Contributor Author

I think this approach to the problem is going to be unworkable down the road. I think much of what we are translating manually here (the nav buttons, the pagination options, etc) needs to be translated by the google translate widget...we are not going to do if/then statements for every language we support, right?

Yes you're right. I think we can only do some of the English-French translation manually for some of text. For other languages, we can use google translate.

@dchiller
Copy link
Contributor

Note also: to the extent that we do store different texts for different languages, there is Django's built-in internationalization protocol: https://docs.djangoproject.com/en/5.1/topics/i18n/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

should the 'French site' default to french for everything?
2 participants