SBB exhibition ETAH2022 #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fungunga
reviewed
Apr 4, 2022
| @@ -63,8 +64,9 @@ GeoTemConfig = { | |||
| // default | |||
| loadColorFromDataset : false, // if DataObject color should be loaded automatically (from column "color") | |||
| allowColumnRenaming : true, | |||
| proxy : '/php/proxy.php?address=', // set this if a HTTP proxy shall be used (e.g. to bypass | |||
| // X-Domain problems) | |||
| // proxy : 'http://b-dev20211109/geo-browser/PLATIN/php/proxy.php?address=', // set this if a HTTP proxy shall be used (e.g. to bypass | |||
There was a problem hiding this comment.
Is this proxy setting ok for the merge to develop?
fungunga
reviewed
Apr 4, 2022
| @@ -52,7 +52,8 @@ GeoTemConfig = { | |||
| incompleteData : true, // show/hide data with either temporal or spatial metadata | |||
| inverseFilter : true, // if inverse filtering is offered | |||
| mouseWheelZoom : true, // enable/disable zoom with mouse wheel on map & timeplot | |||
| language : 'en', // default language of GeoTemCo | |||
| // language : 'en', // default language of GeoTemCo | |||
| language : 'de', // default language of GeoTemCo | |||
There was a problem hiding this comment.
Language should be "en" by default, as it was before?
fungunga
reviewed
Apr 4, 2022
| @@ -273,7 +273,8 @@ function MapConfig(options) { | |||
| bingApiKey : 'none', // bing maps api key, see informations at http://bingmapsportal.com/ | |||
| osmMaps : true, // enable/disable OSM maps | |||
| osmMapsMapQuest : false, // enable/disable OSM maps with MapQuest tiles | |||
| baseLayer : 'terrain', // initial layer to show (e.g. 'Google Streets') | |||
| // baseLayer : 'watercolor', // initial layer to show (e.g. 'Google Streets') | |||
| baseLayer : 'OpenStreetMap', // initial layer to show (e.g. 'Google Streets') | |||
There was a problem hiding this comment.
Check if these new settings can be default…
fungunga
reviewed
Apr 4, 2022
| @@ -301,7 +302,8 @@ function MapConfig(options) { | |||
| maxLabelIncrease : 2, // maximum increase (in em) for the font size of a label | |||
| labelHover : false, // true, to update on label hover | |||
| ieHighlightLabel : "color: COLOR1; background-color: COLOR0; filter:'progid:DXImageTransform.Microsoft.Alpha(Opacity=80)';-ms-filter:'progid:DXImageTransform.Microsoft.Alpha(Opacity=80)';", // css code for a highlighted place label in IE | |||
| highlightLabel : "color: COLOR0; text-shadow: 0 0 0.4em black, 0 0 0.4em black, 0 0 0.4em black, 0 0 0.4em COLOR0;", // css code for a highlighted place label | |||
| // highlightLabel : "color: COLOR0; text-shadow: 0 0 0.4em black, 0 0 0.4em black, 0 0 0.4em black, 0 0 0.4em COLOR0;", // css code for a highlighted place label | |||
| highlightLabel : "color: COLOR0; text-shadow: 0 0 0.4em black, 0 0 0.4em black, 0 0 0.4em black, 0 0 0.4em COLOR1;", // css code for a highlighted place label | |||
There was a problem hiding this comment.
Check if these new settings can be default…
fungunga
reviewed
Apr 4, 2022
| var scaleMode = $(rangeSlider.scalingDropdown).find("option:selected").text(); | ||
| rangeSlider.parent.changeScaleMode(scaleMode); | ||
| }); | ||
| if (!exhibition) { |
There was a problem hiding this comment.
Can we leave a (!exibition) here? Programmatically it seems to be ok, maybe a (exibition) would be better?
fungunga
reviewed
Apr 4, 2022
| /* | ||
| look and fullscreen aren't necessary for exhibition mode | ||
| */ | ||
| if (!(exhibition)) { |
There was a problem hiding this comment.
Same as before: Would an (exibition) be better here?
fungunga
reviewed
Apr 4, 2022
| map.objectLayer.drawFeature(event.feature); | ||
| circle.placenameTags = new PackPlacenameTags(circle,map); | ||
| */ | ||
|
|
There was a problem hiding this comment.
Is comment in comment in comment working? Maybe is is…
fungunga
reviewed
May 5, 2022
| "scaling" : "Skalierung", | ||
| "percentagePlot" : "In Prozent (%)", | ||
| "datedObjects" : "Datierte Treffer", | ||
| "linguaTitle" : "E. T. A. Hoffmanns Werke in aller Welt" |
There was a problem hiding this comment.
Muss hier der spezifische Titel festgelegt werden?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aus CHANGELOG der Hülle DARIAH
Zusammenfassung Änderungen für Ausstellungsversion
Hinzufügen der Komponente Datafilter im PLATIN (4 Dateien)
Hinzufügen einer zentralen Konfigurationsdatei, die nicht im webpack mit gebunden wird.
Erweiterung der Datei js/dariah.geobro.js
-> Ein- und Ausblenden von Elementen, Positionieren von Elementen
Erweiterung der index.html -> Überschriften, Links, ...
Erweiterung der PLATIN/js/Util/Tooltips.js für die (vollständige) Mehrsprachigkeit
Anpassung in der PLATIN/js/Map/MapGui.js
Erweiterung PLATIN/js/Map/MapWidget.js
-> Erzeugung in eigene Funktion ausgelagert builtPlacenameTag()
zusätzliche Parameter in PLATIN/js/FuzzyTimeline/FuzzyTimelineConfig.js
-> Darstellung der x-Achse (Zeit), Einteilung und Stützstellenbestimmung
Anpassung in PLATIN/js/FuzzyTimeline/FuzzyTimelineRangeSlider.js
Erweiterung PLATIN/js/Dataloader/Dataloader.js
Lädt die in embed/js/specialUses.geobro.conf.js als exhibitionFile definierte Datei
Anpassungen im css