Handles polars upgrade to 1.0.0 #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijahbenizzy
force-pushed
the
polars-upgrades
branch
3 times, most recently
from
210c01d
to
dd553cf
Compare
skrawcz
reviewed
Jul 1, 2024
elijahbenizzy
force-pushed
the
polars-upgrades
branch
from
dd553cf
to
457ca76
Compare
Decisions:
1. Not backwards compatible -- we're effectively wrapping the library
and we don't want to provide a bridge. This is polars versioning, not
Hamilton versioning, however, so it's OK to keep this a patch bump
(any polars code would have broken already).
2. They deprecated the usage of a connection string (sqllite://) in the
PolarsDatabase{reader/writer} -- we've deprecated/changed the type as
well
3. It switches based on polars version so people will only get the error
for new polars upgrades
Otherwise, longer term, we're going to want to fix this -- moving away
from these blind wrappers.
elijahbenizzy
force-pushed
the
polars-upgrades
branch
from
457ca76
to
db81d5f
Compare
skrawcz
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decisions:
Otherwise, longer term, we're going to want to fix this -- moving away from these blind wrappers.