Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed
New features
wait_selector
argument withStealthyFetcher
andPlayWrightFetcher
classes, Scrapling will wait again for the JS to fully load and execute like normal. If you used thenetwork_idle
argument, Scrapling will wait for it again too after waiting for all of that. If the states are all fulfilled then no waiting happens, of course.StealthyFetcher
with thedisable_ads
argument. This is enabled by default and it installs theublock origin
addon.PlayWrightFetcher
with thelocale
argument. The default value is stillen-US
.Fetcher
can accept proxies in this formathttp://username:password@localhost:8030
.PlayWrightFetcher
.Bugs Squashed/Improvements
PlayWrightFetcher
class is not tied to thestealth
mode being on or off (Thanks to @AbdullahY36 for pointing that out)ResponseEncoding
tests if the encoding returned from the response can be used with the page or not. If the returned encoding triggered an error, Scrapling defaults toutf-8
Note
A friendly reminder that maintaining and improving
Scrapling
takes a lot of time and effort which I have been happily doing for months even though it's becoming harder. So, if you likeScrapling
and want it to keep improving, you can help by supporting me through the Sponsor button.