Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add generic type UnityAction support & fix typo #621

Merged
merged 5 commits into from
Sep 30, 2024
Merged

add generic type UnityAction support & fix typo #621

merged 5 commits into from
Sep 30, 2024

Conversation

dvsilch
Copy link
Contributor

@dvsilch dvsilch commented Sep 27, 2024

@neuecc
Copy link
Member

neuecc commented Sep 30, 2024

Thank you.
However, I think it should be an argument, not a state, so could you please fix it to arg1, arg2, ...?
Also, is it possible to add an overload for CancellationToken?

@dvsilch
Copy link
Contributor Author

dvsilch commented Sep 30, 2024

Sure, thanks for your review.

@neuecc
Copy link
Member

neuecc commented Sep 30, 2024

thank you!
I'll release soon.

@neuecc neuecc merged commit 647ed6f into Cysharp:master Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvsilch @neuecc