Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): Add starknet gen pubkey #614

Merged
merged 26 commits into from
Jan 10, 2025
Merged

Conversation

vrockz747
Copy link
Collaborator

No description provided.

@vrockz747 vrockz747 force-pushed the feat/starknet/refactored/base branch 2 times, most recently from a1c8c0a to 8a62026 Compare December 13, 2024 14:46
@vrockz747 vrockz747 force-pushed the feat/starknet/refactored/base branch from 8a62026 to 5e805ed Compare December 14, 2024 09:10
@vrockz747 vrockz747 requested a review from TejasvOnly December 14, 2024 09:12
Copy link
Collaborator

@TejasvOnly TejasvOnly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to remove any magic numbers you can by using macros, and add proper error handling.

common/libraries/crypto/mpz_operations/mpz_ecdsa.c Outdated Show resolved Hide resolved
apps/starknet_app/starknet_crypto.c Outdated Show resolved Hide resolved
apps/starknet_app/starknet_helpers.c Outdated Show resolved Hide resolved
apps/starknet_app/starknet_pub_key.c Outdated Show resolved Hide resolved
@vrockz747 vrockz747 force-pushed the feat/starknet/refactored/base branch from 0954644 to 40213ab Compare December 23, 2024 12:25
@vrockz747 vrockz747 force-pushed the feat/starknet/refactored/base branch from 40213ab to bf7396f Compare December 23, 2024 12:27
@vrockz747 vrockz747 requested a review from TejasvOnly December 23, 2024 12:31
@TejasvOnly TejasvOnly force-pushed the feat/starknet/refactored/base branch from b73e5ad to 0eab180 Compare January 9, 2025 11:49
@TejasvOnly TejasvOnly merged commit 4a2dbf9 into develop Jan 10, 2025
6 checks passed
@TejasvOnly TejasvOnly deleted the feat/starknet/refactored/base branch January 10, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants