-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): Add starknet gen pubkey #614
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrockz747
force-pushed
the
feat/starknet/refactored/base
branch
2 times, most recently
from
December 13, 2024 14:46
a1c8c0a
to
8a62026
Compare
vrockz747
force-pushed
the
feat/starknet/refactored/base
branch
from
December 14, 2024 09:10
8a62026
to
5e805ed
Compare
TejasvOnly
requested changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to remove any magic numbers you can by using macros, and add proper error handling.
TejasvOnly
reviewed
Dec 20, 2024
vrockz747
force-pushed
the
feat/starknet/refactored/base
branch
from
December 23, 2024 12:25
0954644
to
40213ab
Compare
vrockz747
force-pushed
the
feat/starknet/refactored/base
branch
from
December 23, 2024 12:27
40213ab
to
bf7396f
Compare
TejasvOnly
approved these changes
Dec 31, 2024
- remove initial release ci code
TejasvOnly
force-pushed
the
feat/starknet/refactored/base
branch
from
January 9, 2025 11:49
b73e5ad
to
0eab180
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.