Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some warnings #606

Merged
merged 1 commit into from
Nov 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apps/manager_app/auth_card.c
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,7 @@ static bool prepare_card_auth_context(auth_card_data_t *auth_card_data) {
} else {
snprintf(auth_card_data->ctx.heading,
sizeof(auth_card_data->ctx.heading),
"%s",
ui_text_tap_a_card);
}

Expand Down Expand Up @@ -372,6 +373,7 @@ static bool handle_sign_challenge(auth_card_data_t *auth_card_data) {
} else {
snprintf(auth_card_data->ctx.message,
sizeof(auth_card_data->ctx.message),
"%s",
ui_text_processing);
}

Expand Down Expand Up @@ -445,7 +447,7 @@ static bool handle_auth_card_result_query(auth_card_data_t *auth_card_data) {
uint32_t pairing_status = DEFAULT_VALUE_IN_FLASH;
if (CARD_OPERATION_SUCCESS !=
card_pair_without_retap(card_number, &pairing_status)) {
LOG_ERROR("pairing error: %ld", pairing_status);
LOG_ERROR("pairing error: %d", pairing_status);
manager_send_error(ERROR_COMMON_ERROR_CARD_ERROR_TAG,
get_card_error_from_nfc_status(pairing_status));
if (SW_CONDITIONS_NOT_SATISFIED != pairing_status &&
Expand Down
6 changes: 4 additions & 2 deletions src/settings/card_health_check.c
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,10 @@ void card_health_check(void) {

char wallet_list[MAX_WALLETS_ALLOWED][NAME_SIZE] = {"", "", "", ""};
for (uint8_t i = 0; i < wallets_in_card.count; i++) {
snprintf(
wallet_list[i], NAME_SIZE, (char *)wallets_in_card.wallet[i].name);
snprintf(wallet_list[i],
NAME_SIZE,
"%s",
(char *)wallets_in_card.wallet[i].name);
}
list_init(wallet_list, wallets_in_card.count, display_msg, false);

Expand Down
3 changes: 2 additions & 1 deletion src/settings/view_device_info.c
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ void view_device_regulatory_information(void) {
for (uint8_t slide = 0; slide < NUMBER_OF_SLIDES_REGULATORY_INFO; slide++) {
snprintf(content[slide + 1].text,
sizeof(content[slide + 1].text),
"%s",
ui_text_regulatory_info[slide]);
}

Expand All @@ -155,4 +156,4 @@ void view_device_regulatory_information(void) {
// Do not care about the return value from confirmation screen
(void)get_state_on_confirm_scr(0, 0, 0);
return;
}
}