Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): Refactor session #560

Merged
merged 36 commits into from
Nov 14, 2024
Merged

chore(core): Refactor session #560

merged 36 commits into from
Nov 14, 2024

Conversation

vrockz747
Copy link
Collaborator

No description provided.

@vrockz747 vrockz747 force-pushed the fix/inheritance/session-refactor branch from 7171b8a to 79e5ead Compare September 19, 2024 19:27
@vrockz747 vrockz747 force-pushed the fix/inheritance/session-refactor branch from 79e5ead to a7a2d5f Compare September 19, 2024 19:32
@vrockz747 vrockz747 changed the title Fix/inheritance/session refactor chore(core): Refactor session Sep 20, 2024
vrockz747
vrockz747 commented Sep 20, 2024
View reviewed changes
common/core/core_session.c Outdated Show resolved Hide resolved
TejasvOnly
TejasvOnly requested changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@TejasvOnly TejasvOnly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also take care of USE_SIMULATOR macros in this pr itself?

common/core/core_session.c Outdated Show resolved Hide resolved
common/core/core_session.c Outdated Show resolved Hide resolved
common/core/core_session.c Outdated Show resolved Hide resolved
common/core/core_session.c Outdated Show resolved Hide resolved
@vrockz747
Copy link
Collaborator Author

Can we also take care of USE_SIMULATOR macros in this pr itself?

I was thinking of fixing it in the error handling PR, but will do in this only

@vrockz747 vrockz747 closed this Sep 20, 2024
@vrockz747 vrockz747 reopened this Sep 20, 2024
TejasvOnly
TejasvOnly requested changes Sep 23, 2024
View reviewed changes
common/core/core_session.h Outdated Show resolved Hide resolved
common/core/core_session.c Show resolved Hide resolved
@vrockz747 vrockz747 force-pushed the fix/inheritance/session-refactor branch from 34b7d65 to ecb81d2 Compare October 3, 2024 08:09
@vrockz747 vrockz747 force-pushed the fix/inheritance/session-refactor branch 2 times, most recently from 43f4dd2 to dc5e2d9 Compare October 7, 2024 08:05
@vrockz747 vrockz747 requested a review from TejasvOnly November 11, 2024 11:48
@TejasvOnly TejasvOnly force-pushed the fix/inheritance/session-refactor branch 2 times, most recently from 8fe30a1 to f45c573 Compare November 11, 2024 23:37
@TejasvOnly TejasvOnly force-pushed the feat/inheritance/base branch from 5cae0c5 to 1cb87c1 Compare November 12, 2024 06:11
vrockz747 and others added 18 commits November 11, 2024 22:11
@vrockz747 @TejasvOnly
chore(core): Refactor session
f4f2896
@vrockz747 @TejasvOnly
fix: Minor bug
2a24211
@vrockz747 @TejasvOnly
chore: Review changes
7f8dcf2
@vrockz747 @TejasvOnly
chore: Review changes
2c8db6d
@vrockz747 @TejasvOnly
Merge branch 'tests/inheritance/encryption' into feat/inheritance/dec…
d82ed1f 
…ryption-error-handling
@vrockz747 @TejasvOnly
Merge branch 'feat/inheritance/encryption-error-handling' of github.c…
750312e 
…om:Cypherock/x1_wallet_firmware into tests/inheritance/encryption
@vrockz747 @TejasvOnly
Merge branch 'feat/inheritance/base' into feat/inheritance/decryption…
f380d0e 
…-error-handling
@TejasvOnly
Merge pull request #570 from Cypherock/tests/inheritance/encryption
72f8e3b
@TejasvOnly
Merge pull request #573 from Cypherock/feat/inheritance/decryption-er…
5993d07 
…ror-handling
@TejasvOnly
Merge pull request #561 from Cypherock/feat/inheritance/session-error…
4f267b0 
…-handling
@vrockz747 @TejasvOnly
Merge branch 'fix/inheritance/session-refactor' into feat/inheritance…
5d84451 
…/session-error-handling
@vrockz747 @TejasvOnly
Merge branch 'feat/inheritance/base' into fix/inheritance/session-ref…
f397ed6 
…actor
@vrockz747 @TejasvOnly
Merge branch 'fix/inheritance/session-refactor' into tests/inheritanc…
764f9b0 
…e/session
@vrockz747 @TejasvOnly
chore: Add core session error tag
038672c
@vrockz747 @TejasvOnly
fix: Bug fix
122f845
@vrockz747 @TejasvOnly
chore: Update submodule
0546984
@TejasvOnly
Merge pull request #563 from Cypherock/tests/inheritance/session
03d4921
@TejasvOnly
Merge pull request #588 from Cypherock/feat/inheritance/core-session-…
96be6ed 
…error-tag
@TejasvOnly TejasvOnly force-pushed the fix/inheritance/session-refactor branch from f45c573 to 96be6ed Compare November 12, 2024 06:18
@TejasvOnly TejasvOnly merged commit e3d6f63 into feat/inheritance/base Nov 14, 2024
8 checks passed
@TejasvOnly TejasvOnly deleted the fix/inheritance/session-refactor branch November 14, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TejasvOnly TejasvOnly Awaiting requested review from TejasvOnly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vrockz747 @TejasvOnly