Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Handle wallet collision while creation #444

Conversation

amanCypherock
Copy link
Contributor

This PR is part-1 of wallet verification through nonce.

Changes:

  • On wallet creation, a random nonce(common to each share) of 12 bytes is generated and stored on cards and the device.
  • On wallet sync flow, the random nonce received from the wallet on the card is stored on flash.

@amanCypherock amanCypherock added the enhancement Improvements to an existing feature label Nov 27, 2023
@amanCypherock amanCypherock self-assigned this Nov 27, 2023
@rohanagarwal94
Copy link

src/wallet/create_new_wallet_flow.c Show resolved Hide resolved
src/wallet/create_new_wallet_flow.c Outdated Show resolved Hide resolved
src/wallet/create_new_wallet_flow.c Outdated Show resolved Hide resolved
amanCypherock and others added 19 commits December 20, 2023 12:19
…-6557

feat(core): Verify fetched wallets
…efore-delete

fix(core): Treat unverified wallets as non existant
…dated

fix(core): Update factory reset condition to ignore write attempt
@ujjwal-cyph ujjwal-cyph changed the title feat(core): Save wallet nonce while creation feat(core): Handle wallet collision while creation Dec 27, 2023
Copy link
Collaborator

@ujjwal-cyph ujjwal-cyph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amanCypherock amanCypherock merged commit 1eb7daf into refactor/core-framework Dec 27, 2023
13 checks passed
@amanCypherock amanCypherock deleted the feat/save-wallet-nonce-on-creation/PRF-6203 branch December 27, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants