-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Handle wallet collision while creation #444
Merged
amanCypherock
merged 24 commits into
refactor/core-framework
from
feat/save-wallet-nonce-on-creation/PRF-6203
Dec 27, 2023
Merged
feat(core): Handle wallet collision while creation #444
amanCypherock
merged 24 commits into
refactor/core-framework
from
feat/save-wallet-nonce-on-creation/PRF-6203
Dec 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujjwal-cyph
requested changes
Dec 15, 2023
ujjwal-cyph
reviewed
Dec 19, 2023
…-creation/PRF-6203
…-6557 feat(core): Verify fetched wallets
…6558 Verify wallet before delete
…efore-delete fix(core): Treat unverified wallets as non existant
…dated fix(core): Update factory reset condition to ignore write attempt
…-creation/PRF-6203
ujjwal-cyph
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part-1 of wallet verification through nonce.
Changes: