Repository navigation
Conversation
Member
|
Thanks for the PR, but could you first explain the bug/problem you are running into? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetworkWorldStorage.beforeSave appends to networkParams without clearing the previous snapshot. Repeated saves retain stale networks and duplicate current entries.
Build a complete snapshot first, then replace the saved list. Network.toParams also preserves toRead until deferred loading completes, so an early startup save cannot discard the pending paths or crash state. A failed snapshot producer leaves the prior snapshot intact. This does not reconnect cables or rebuild networks.
The full build and all 1,102 game tests pass locally, including three new serialization regressions. Validation used NeoForge 126 and the deployed CyclopsCore 1.31.4/CommonCapabilities 2.11.8 plus bundled compat classes, substituted through a local init script because the declared GitHub Packages dependencies returned 401. The modified methods also pass a native modpack fixture. No graphical gameplay or performance benchmark was performed.