Skip to content

Conversation

@Mehrn0ush
Copy link
Contributor

As discussed in ticket #763, this PR adds AES-SIV (RFC 5297) as an AEAD variant to the Cryptography Registry.

Fixes #763

Details

  • Adds AES[-(128|192|256)]-SIV as an ae variant under the existing AES family.
  • Adds authoritative standards reference for RFC 5297.
  • Registry-only change (schema/cryptography-defs.json). No schema or specification behavior changes.

@Mehrn0ush Mehrn0ush requested a review from a team as a code owner January 6, 2026 13:18
@stevespringett stevespringett added cap: cryptography Capability: Cryptography (CBOM) cap: cryptography-registry Capability: Cryptography Registry labels Jan 8, 2026
@stevespringett
Copy link
Member

@bhess

Copy link
Contributor

@bhess bhess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds AES-SIV (Synthetic Initialization Vector) as a new AEAD variant to the cryptography registry, addressing issue #763. AES-SIV is defined in RFC 5297 and provides deterministic authenticated encryption with associated data (AEAD).

Changes:

  • Adds AES-SIV variant with support for 128, 192, and 256-bit key sizes
  • Includes authoritative RFC 5297 standard reference with DOI URL
  • Classified as an authenticated encryption (ae) primitive within the AES algorithm family

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

{
"standard": [
{
"name": "RFC 5297",
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RFC naming format is inconsistent with most other RFC references in this file. The majority of RFC references use no space (e.g., 'RFC5649' at line 354, 'RFC5869' at line 375, 'RFC8017', 'RFC2104'), while this uses 'RFC 5297' with a space. Although this matches the nearby 'RFC 5116' and 'RFC 3610' references within the AES family, consider using the more common format 'RFC5297' without a space for consistency across the entire file.

Suggested change
"name": "RFC 5297",
"name": "RFC5297",

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cap: cryptography Capability: Cryptography (CBOM) cap: cryptography-registry Capability: Cryptography Registry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Add AES-SIV (RFC 5297) AEAD variant to Cryptography Registry

3 participants