-
-
Notifications
You must be signed in to change notification settings - Fork 81
feat(registry): add AES-SIV AEAD variant (RFC 5297) #764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Mehrn0ush <[email protected]>
bhess
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds AES-SIV (Synthetic Initialization Vector) as a new AEAD variant to the cryptography registry, addressing issue #763. AES-SIV is defined in RFC 5297 and provides deterministic authenticated encryption with associated data (AEAD).
Changes:
- Adds AES-SIV variant with support for 128, 192, and 256-bit key sizes
- Includes authoritative RFC 5297 standard reference with DOI URL
- Classified as an authenticated encryption (
ae) primitive within the AES algorithm family
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| "standard": [ | ||
| { | ||
| "name": "RFC 5297", |
Copilot
AI
Jan 15, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RFC naming format is inconsistent with most other RFC references in this file. The majority of RFC references use no space (e.g., 'RFC5649' at line 354, 'RFC5869' at line 375, 'RFC8017', 'RFC2104'), while this uses 'RFC 5297' with a space. Although this matches the nearby 'RFC 5116' and 'RFC 3610' references within the AES family, consider using the more common format 'RFC5297' without a space for consistency across the entire file.
| "name": "RFC 5297", | |
| "name": "RFC5297", |
As discussed in ticket #763, this PR adds AES-SIV (RFC 5297) as an AEAD variant to the Cryptography Registry.
Fixes #763
Details
AES[-(128|192|256)]-SIVas anaevariant under the existingAESfamily.schema/cryptography-defs.json). No schema or specification behavior changes.