[ISSUE-196] Fix JSON schema inconsistency#197
Open
jameskim0987 wants to merge 3 commits intoCycloneDX:masterfrom
Open
[ISSUE-196] Fix JSON schema inconsistency#197jameskim0987 wants to merge 3 commits intoCycloneDX:masterfrom
jameskim0987 wants to merge 3 commits intoCycloneDX:masterfrom
Conversation
d46c295 to
4c3f071
Compare
Member
|
Thanks for the PR @jameskim0987! Unfortunately it's the opposite of what needs to be done. The schema is defined by the CycloneDX specification: https://github.com/CycloneDX/specification/tree/master/schema But our Go code is not adhering to it correctly, as detailed in #196. So the solution would be to modify the Go code, not the schema. |
Signed-off-by: James Kim <kgh475926@gmail.com>
Signed-off-by: James Kim <kgh475926@gmail.com>
Signed-off-by: James Kim <kgh475926@gmail.com>
f031bdf to
e3b655e
Compare
Author
|
@nscuro Thanks for the clarification. I made the small change to the field type.
|
Author
|
@nscuro Hi, would you be able to address the comment above when you get a chance? Thank you! |
Contributor
|
Hello @nscuro Is there a chance this PR will be merged? Best regards, Dmitriy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #196
Changes made in this PR:
1. fix typearraytoobjectsince Data is of type pointer to ComponentData