Use of CSI Driver #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for modular control over backend hostname.i
cccs-rs
reviewed
Dec 13, 2023
…ssemblyline-helm-chart into Secret-Provider-Class * 'Secret-Provider-Class' of https://github.com/C-Oliver/assemblyline-helm-chart: Make 'curl' command in create-certs container retry on 'connection refused' errors to address a timing issue. Propagate failure code from curl using && to prevent false success indication from create-certs container. Only setup elastic-helper if setting up an internal Elasticsearch instance Add missing $ anchor .Values reference in jobs.yaml
|
@cccs-rs realised I had not updated this PR with the change requested. Done now, should be good, let me know if you need any other changes done. |
cccs-rs
reviewed
Feb 15, 2024
cccs-rs
requested changes
Feb 15, 2024
|
I don't really have anything substantial to add. |
|
Checking in on this so that we stay up to date with master if possible. |
cccs-rs
reviewed
May 9, 2024
cccs-rs
reviewed
Jun 26, 2024
cccs-sgaron
requested changes
Jun 26, 2024
There was a problem hiding this comment.
I have a few change request for the number of UI workers and max connections but for the rest, I will let @cccs-douglass and @cccs-rs make the call.
|
Are we okay to merge this to Dev ? |
cccs-rs
reviewed
Jul 16, 2024
cccs-rs
approved these changes
Jul 16, 2024
cccs-rs
approved these changes
Jul 17, 2024
cccs-douglass
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[+] Use SecretProviderClass for certificates
[+] Split out Ingress.yaml for better modular control over backend hostnames
[+] Fixed wrong tag on jobs.yaml