Swap 'special' and 'unknown' in enum, so that 'unknown' is default #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If 'special' is the default for unknown options then dhcptest refuses to accept them, with 'Fatal error: Can't specify a value for special option NN' when there is no format specifed, or with an assertion at line 616 for basically the same reason, if there is a format specifier. Swapping so that 'unknown' is the default means that unknown options can be successfully manually specified.
|
Here is an example command which works after the change but won't work before the change: and a screenshot from Wireshark showing that we have specified a valid value for a valid option: 
While it might also be useful to do a PR to make 93 a known option, I think it is definitely useful to allow unknown options to be specified like this. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If 'special' is the default for unknown options then dhcptest refuses to accept them, with 'Fatal error: Can't specify a value for special option NN' when there is no format specifed, or with an assertion at line 616 for basically the same reason, if there is a format specifier.
Swapping so that 'unknown' is the default means that unknown options can be successfully manually specified.