-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds basic raid protection. #610
Adds basic raid protection. #610
Conversation
Initial commit including new command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good so far!
What about the default invite thats mapped to that domain beano has |
@Sh3llcod3 requested this
So, that can either be reinstated manually or we could add some functionality that hits Cloudflare's API to update it. |
Avoids checking bool twice unnecessarily
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it'll work, I'll approve it properly once I've tested it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I've now tested this. I'm happy that it works, but there's a couple small tweaks I'd like before merging.
- Can we put the admin's name in the audit log please. I know it goes to
#log
, but having it in both would be nice - I'm not a massive fan of having this as a toggle. I think it would work better as the base command showing you the current value, then you having to specify off/on. The current model has too high a chance for accidently toggling it to the wrong value because you don't know the current value.
Ok, I'll get right on it. |
… toggle, :raid will fetch status and :raid [on/off] sets. I also renamed it to just :raid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do it
This "starts the ball rolling" on issue #369 - a simple toggle command that toggles the ability of @.everyone to create instant invites, and on the ON toggle will delete all invites. It also sends a log to the logging channel. It is a root only command.
The code does work, but I'm making it a draft for now because I think we can add some extra functionality. Please voice your suggestions.