Conversation
There was a problem hiding this comment.
Pull request overview
このPRは「デプロイ001」として、依存関係管理（pnpm）とフロントエンドビルド設定を本番向けに寄せつつ、クライアント側のバンドル最適化（コード分割等）を進める変更です。
Changes:
- scoring-tool 側の pnpm workspace 設定（packages 追加）と lockfile 更新（ただし lighthouse パッチ適用が lock に反映されていない状態）
- application 側の lockfile 更新（ただし gifler→bluebird の override が lock に反映されていない状態）
- client ビルドを production 前提に変更（webpack/babel 設定更新、HTML 自動 inject、React.lazy による分割）
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| scoring-tool/pnpm-workspace.yaml | workspace の packages 定義を追加 |
| scoring-tool/pnpm-lock.yaml | lock 更新（lighthouse パッチ情報が消えている） |
| application/pnpm-lock.yaml | lock 更新（gifler の bluebird が 3.0.2 に固定されている） |
| application/client/webpack.config.js | production ビルド設定・HTML inject・splitChunks 有効化 |
| application/client/src/index.html | 手動 script/link を削除（HtmlWebpackPlugin inject 前提） |
| application/client/src/containers/AppContainer.tsx | 画面コンテナを React.lazy + Suspense で分割 |
| application/client/src/components/crok/CodeBlock.tsx | react-syntax-highlighter を Light 版 + 言語登録に変更 |
| application/client/package.json | build を NODE_ENV=production で実行 |
| application/client/babel.config.js | 対象ブラウザ更新、modules/useBuiltIns 設定を変更 |
Files not reviewed (2)
- application/pnpm-lock.yaml: Language not supported
- scoring-tool/pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| modules: "commonjs", | ||
| useBuiltIns: false, | ||
| modules: false, | ||
| useBuiltIns: "usage", |
There was a problem hiding this comment.
@babel/preset-env is now configured with useBuiltIns: "usage", but the webpack entry still imports core-js (and regenerator-runtime/runtime). Keeping core-js in the entry typically pulls in a large global polyfill bundle and can duplicate polyfills, largely negating the benefit of usage. Either remove the core-js (and possibly regenerator) entries and rely on usage, or revert to an entry-based polyfill strategy (e.g., useBuiltIns: false/entry) so the configuration is consistent.
| useBuiltIns: "usage", | |
| useBuiltIns: "entry", |
No description provided.