Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[swerve] Broken command mutexing with Orchestra #80

Closed
spacey-sooty opened this issue Jul 10, 2024 · 1 comment
Closed

[swerve] Broken command mutexing with Orchestra #80

spacey-sooty opened this issue Jul 10, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@spacey-sooty
Copy link
Member

Currently we expose the Orchestra to outside callers through the getOrchestra() function. This is fundamentally flawed with the Command based system as it exposes write access to the state of swerve motors without going through the Command API.
This is slightly more trivially to fix while maintaining current features as #79 tried due to the way Triggers work with rising and falling edges.
@spacey-sooty spacey-sooty added the bug Something isn't working label Jul 10, 2024
@spacey-sooty
Copy link
Member Author

Removed orchestra in #85

@spacey-sooty spacey-sooty closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spacey-sooty