-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LED's to display robot state #46
Conversation
Resolves #15 Closes #39 Co-authored-by: Jade <[email protected]> Co-authored-by: koz <[email protected]>
d776edb
to
f1a8f1b
Compare
/format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should display info about intaking and robot position as well.
Needs coordination with driveteam and @totallysomeoneyoudontknow
cc @Hazzer890 I'm sure you have an opinion on what the LEDs should do
lEDPwm.setSpeed(0.67); | ||
break; | ||
|
||
case kIntake: | ||
case kSpeaker: | ||
position = 3.7; | ||
lEDPwm.setSpeed(0.73); | ||
break; | ||
|
||
case kSpeaker: | ||
case kIntake: | ||
position = 3.7; | ||
lEDPwm.setSpeed(0.57); | ||
break; | ||
|
||
case kStowed: | ||
position = 3.7; | ||
lEDPwm.setSpeed(0.99); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we have comments to say what that actually displays, its not obvious from the code
@@ -42,6 +43,8 @@ public enum Setpoint { | |||
private DoubleLogEntry log_ff_output = new DoubleLogEntry(m_log, "/arm/ff/output"); | |||
private StringLogEntry log_setpoint = new StringLogEntry(m_log, "/arm/setpoint"); | |||
|
|||
PWM lEDPwm = new PWM(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this port needs to be determined still no?
PWM lEDPwm = new PWM(0); | |
private PWM m_led = new PWM(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this port needs to be determined still no?
maybe, was going off memory, could also be port 1
currently working off LED patterns decided with Layla during season. |
lEDPwm.setSpeed(0.67); // gold // | ||
break; | ||
|
||
case kIntake: | ||
case kSpeaker: | ||
position = 3.7; | ||
lEDPwm.setSpeed(0.73); // lime // | ||
break; | ||
|
||
case kSpeaker: | ||
case kIntake: | ||
position = 3.7; | ||
lEDPwm.setSpeed(0.57); // hot pink // | ||
break; | ||
|
||
case kStowed: | ||
position = 3.7; | ||
lEDPwm.setSpeed(0.99); // blank // |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove trailing slashes
0c58f49
to
f6c5cc0
Compare
Finished LED integration within arm states
Resolves #40