Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wombat] fix warnings #31

Merged
merged 6 commits into from
Dec 31, 2023
Merged

[wombat] fix warnings #31

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
91dd152
[wombat] fix warnings
spacey-sooty Dec 26, 2023
1438b39
remove default
spacey-sooty Dec 26, 2023
775be96
Merge branch 'master' into spacey-sooty/warnings
spacey-sooty Dec 31, 2023
8866426
Merge branch 'master' into spacey-sooty/warnings
spacey-sooty Dec 31, 2023
f4f887a
Merge branch 'master' into spacey-sooty/warnings
spacey-sooty Dec 31, 2023
6fd58f0
Merge branch 'master' into spacey-sooty/warnings
spacey-sooty Dec 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions wombat/src/main/include/utils/Encoder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ namespace wom {
namespace utils {
class Encoder {
public:
Encoder(double encoderTicksPerRotation, double reduction, int type) : _encoderTicksPerRotation(encoderTicksPerRotation), _reduction(reduction), _type(type) {};
Encoder(double encoderTicksPerRotation, double reduction, int type) : _reduction(reduction), _encoderTicksPerRotation(encoderTicksPerRotation), _type(type) {};
virtual double GetEncoderRawTicks() const = 0;
virtual double GetEncoderTickVelocity() const = 0; // ticks/s
virtual void ZeroEncoder();
Expand All @@ -32,7 +32,7 @@ namespace utils {
units::radians_per_second_t GetEncoderAngularVelocity(); // rad/s

int encoderType = 0;
double _reduction = 1.0;
double _reduction;
spacey-sooty marked this conversation as resolved.
Show resolved Hide resolved
private:
double _encoderTicksPerRotation;
units::radian_t _offset = 0_rad;
Expand Down