Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wombat/behaviours] Create Trigger API #128

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

spacey-sooty
Copy link
Member

@spacey-sooty spacey-sooty commented Feb 9, 2024

The trigger API is a way to bind a Behaviour to a booolean. This approach has a variety of benefits. Primarily it allows us to avoid binding buttons multiple times. This was heavily inspired by the WPILib Trigger API, docs found here

TODO

  • add trigger classes
  • update scheduler to add triggers
  • create xbox trigger controller
  • test on a robot
  • refactor existing code to use Triggers

@spacey-sooty spacey-sooty added enhancement New feature or request Wombat This relates to Wombat (also create a mirror issue there) labels Feb 9, 2024
@spacey-sooty spacey-sooty self-assigned this Feb 9, 2024
@spacey-sooty spacey-sooty requested a review from a team as a code owner February 9, 2024 12:21
wombat/src/main/include/behaviour/Trigger.h Outdated Show resolved Hide resolved
wombat/src/main/include/behaviour/TriggerXboxController.h Outdated Show resolved Hide resolved
wombat/src/main/include/behaviour/BehaviourScheduler.h Outdated Show resolved Hide resolved
wombat/src/main/include/behaviour/Trigger.h Show resolved Hide resolved
wombat/src/main/include/behaviour/Trigger.h Outdated Show resolved Hide resolved
wombat/src/main/include/behaviour/Trigger.h Show resolved Hide resolved
wombat/src/main/include/behaviour/Trigger.h Show resolved Hide resolved
wombat/src/main/include/behaviour/Trigger.h Show resolved Hide resolved
wombat/src/main/include/behaviour/Trigger.h Outdated Show resolved Hide resolved
goanna247
goanna247 previously approved these changes Feb 10, 2024
Copy link
Member Author

@spacey-sooty spacey-sooty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to add threshold triggers to TriggerXboxController

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Wombat This relates to Wombat (also create a mirror issue there)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants