-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wombat/behaviours] Create Trigger API #128
Open
spacey-sooty
wants to merge
12
commits into
master
Choose a base branch
from
spacey-sooty/trigger-api
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vyppal
reviewed
Feb 9, 2024
goanna247
previously approved these changes
Feb 10, 2024
spacey-sooty
commented
Feb 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to add threshold triggers to TriggerXboxController
715ad07
to
02cd628
Compare
ebec657
to
4f4866b
Compare
The trigger API is a way to bind a Behaviour to a booolean. This approach has a variety of benefits. Primarily it allows us to avoid binding buttons multiple times. This was heavily inspired by the WPILib Trigger API docs found [here](https://docs.wpilib.org/en/stable/docs/software/commandbased/binding-commands-to-triggers.html)
4f4866b
to
5a388c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trigger API is a way to bind a Behaviour to a booolean. This approach has a variety of benefits. Primarily it allows us to avoid binding buttons multiple times. This was heavily inspired by the WPILib Trigger API, docs found here
TODO