Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign Up form and Profile Page #14

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Sign Up form and Profile Page #14

wants to merge 35 commits into from

Conversation

siddharthborderwala
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Jun 2, 2022

Deploy Preview for ambassadors-dao-dev ready!

Name Link
🔨 Latest commit f2854b8
🔍 Latest deploy log https://app.netlify.com/sites/ambassadors-dao-dev/deploys/62a4d58c6d965c00090fac6c
😎 Deploy Preview https://deploy-preview-14--ambassadors-dao-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

pages/v2/signUp.tsx Outdated Show resolved Hide resolved
pages/v2/signUp.tsx Outdated Show resolved Hide resolved
pages/v2/signUp.tsx Outdated Show resolved Hide resolved
@siddharthborderwala
Copy link
Contributor Author

siddharthborderwala commented Jun 2, 2022

Take care of the sizing of the page, as you can see there is a lot of whitespace below the body.
image

Also please remove the extra inputs from the top.
image

@siddharthborderwala
Copy link
Contributor Author

siddharthborderwala commented Jun 2, 2022

These inputs look like they are disabled, change their background colors
image

The tags look pretty, a couple of changes. The available tags do not need a right tick mark.
image

Make the chosen tags such that only clicking the cross icon removes them. Have a different background for the cross icon, that will look even better.
image

The functionality is proper! Good going

@siddharthborderwala
Copy link
Contributor Author

siddharthborderwala commented Jun 3, 2022

Need to change the edit button for profile picture, I will explain what exactly to do.
image

Change the background of the upper two inputs to match the background of the lower two inputs. The darker background makes it seem like the inputs are disabled.
image

Revert the tags cross icon to have transparent background. This does not look good as you mentioned.
image

@siddharthborderwala
Copy link
Contributor Author

siddharthborderwala commented Jun 10, 2022

The labels cannot go over this line of alignment. Also, the collection of 5 things should be center aligned, vertically. Also change the label for referral to "Received from a Voyager". Also change the referral label icon, it is the same as a referral.
image

Need a preview of the data at the last page, instead of normal inputs, we will have disabled inputs. And also need a checkbox saying "I agree to follow the community guidelines on the DAO" and a submit button.

OMG why are these buttons divs?
image

Also, the user should only be able to go to next page if the inputs on current page are valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants