Accept log_destination with instrumentation enabled #4327
+179
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Equal is one of the few expectations we can use in our test suite.
Existing deployments may already be using one of these structured formats. Postgres can log in multiple formats simultaneously, allowing a custom solution to run alongside OpenTelemetry collection. Regardless of the number of formats are emitted by Postgres, the collector is now configured to scrape the preferred format for a particular version of Postgres. When blank, Postgres will emit *no* logs after startup. This does not introduce any new validation in that regard. Issue: PGO-2423
cbandy
force-pushed
the
log-destinations
branch
from
5319c29 to
f88829b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing deployments may already be using one of these structured formats. Postgres can log in multiple formats simultaneously, allowing a custom solution to run alongside OpenTelemetry collection.
Regardless of the number of formats emitted by Postgres, the collector is now configured to scrape the preferred format for a particular version of Postgres.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
Postgres logs to exactly one
log_destinationwhen OpenTelemetry logs are enabled.What is the new behavior (if this is a feature change)?
One can specify multiple
log_destinationand OpenTelemetry will scrape the format it prefers.Other Information:
When blank, Postgres will emit no logs after startup. This does not introduce any new validation in that regard.
Issue: PGO-2423